Repository navigation
Make the precondition retry test independent of machine speed - #62
Merged
Merged
Conversation
The test hung the first looks for 3 s and relied on a 400 ms navigation timeout, which a slow runner exceeded for the looks that should work. A server that is not up yet refuses connections at once, so a look fails the same way everywhere. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
That depends on how fast the runner starts a context. The give-up case still asserts the exact count against a server that never starts. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main CI failed on ubuntu after #61:
LooksThatFailAreRetriedAndGiveUpAfterTheRetrieshung the first looks for 3 s and relied on a 400 ms navigation timeout. A slow runner exceeded that for the looks that should have worked, so all three looks failed.The test server now starts late, or never. Until it starts, the port refuses connections, so a look fails at once on any machine. The retry and give-up checks are the same; the give-up case also asserts the refused-connection error.
I ran the precondition tests three times locally, all green.
🤖 Generated with Claude Code