Skip to content

Make the precondition retry test independent of machine speed - #62

Merged
Mpdreamz merged 2 commits into
mainfrom
precondition-test-deterministic
Nov 17, 2026
Merged

Mpdreamz merged 2 commits into
mainfrom
precondition-test-deterministic

Conversation

@Mpdreamz

Copy link
Copy Markdown
Contributor

Main CI failed on ubuntu after #61: LooksThatFailAreRetriedAndGiveUpAfterTheRetries hung the first looks for 3 s and relied on a 400 ms navigation timeout. A slow runner exceeded that for the looks that should have worked, so all three looks failed.

The test server now starts late, or never. Until it starts, the port refuses connections, so a look fails at once on any machine. The retry and give-up checks are the same; the give-up case also asserts the refused-connection error.

I ran the precondition tests three times locally, all green.

🤖 Generated with Claude Code

The test hung the first looks for 3 s and relied on a 400 ms navigation timeout,
which a slow runner exceeded for the looks that should work. A server that is
not up yet refuses connections at once, so a look fails the same way everywhere.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@Mpdreamz Mpdreamz added the changelog:skip Left out of the release notes label Nov 17, 2026
That depends on how fast the runner starts a context. The give-up case still
asserts the exact count against a server that never starts.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@Mpdreamz
Mpdreamz merged commit 19f8e8d into main Nov 17, 2026
12 checks passed
@Mpdreamz
Mpdreamz deleted the precondition-test-deterministic branch November 17, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip Left out of the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant